Skip to content

Usability upgrades to V4 Migration Guide #2095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 19, 2025
Merged

Usability upgrades to V4 Migration Guide #2095

merged 10 commits into from
May 19, 2025

Conversation

nandan-bhat
Copy link
Contributor

Changes

@nandan-bhat nandan-bhat requested a review from a team as a code owner May 13, 2025 22:04
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.46%. Comparing base (b7f7d38) to head (045a8c4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2095   +/-   ##
=======================================
  Coverage   82.46%   82.46%           
=======================================
  Files          21       21           
  Lines        2024     2024           
  Branches      355      355           
=======================================
  Hits         1669     1669           
  Misses        348      348           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tusharpandey13
tusharpandey13 previously approved these changes May 14, 2025
@tusharpandey13 tusharpandey13 changed the title Addressing GitHub issue 1983 Usability upgrades to V4 Migration Guide May 15, 2025
@arpit-jn arpit-jn requested a review from dennishenry May 15, 2025 10:47
Copy link

@dennishenry dennishenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits

dennishenry
dennishenry previously approved these changes May 15, 2025
Copy link
Member

@frederikprijck frederikprijck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments, can we also use absolute URLs to links that go to other files, to ensure the links also work on the API docs?

@arpit-jn arpit-jn merged commit 9388534 into main May 19, 2025
12 checks passed
@arpit-jn arpit-jn deleted the fix/issue-1983 branch May 19, 2025 12:18
@tusharpandey13 tusharpandey13 mentioned this pull request May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants