-
Notifications
You must be signed in to change notification settings - Fork 422
Usability upgrades to V4 Migration Guide #2095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2095 +/- ##
=======================================
Coverage 82.46% 82.46%
=======================================
Files 21 21
Lines 2024 2024
Branches 355 355
=======================================
Hits 1669 1669
Misses 348 348
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments, can we also use absolute URLs to links that go to other files, to ensure the links also work on the API docs?
Changes
middleware
example. Will follow up with additional guidance on advanced middleware usage in a future update.V4_MIGRATION_GUIDE
.V4_MIGRATION_GUIDE
.